[PATCH] D132205: [llvm-tblgen] CodeGenSchedModels::hasReadOfWrite gets wrong predication result

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 07:24:52 PDT 2022


RKSimon added a comment.

In D132205#3771221 <https://reviews.llvm.org/D132205#3771221>, @zixuan-wu wrote:

> In D132205#3769775 <https://reviews.llvm.org/D132205#3769775>, @RKSimon wrote:
>
>> Does this fix PR57548?
>
> I am not sure. It just influences the number of cycle, which make it more accurate.

My mistake (the bug + this patch were just coincidental) - @andreadb fixed the bug with rG3262794804ad23ed4a511669ffc97d128512bc37 <https://reviews.llvm.org/rG3262794804ad23ed4a511669ffc97d128512bc37>

Do you have real world test cases for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132205/new/

https://reviews.llvm.org/D132205



More information about the llvm-commits mailing list