[PATCH] D131571: [AArch64][SME] Fix lowering of llvm.aarch64.get.pstatesm()

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/IR/CallingConv.h:255
 
+    /// Preserve X0-X13, X19-X29, SP, Z0-Z31, P0-P15.
+    AArch64_SME_ABI_Support_Routines_PreserveMost = 102,
----------------
david-arm wrote:
> Is this right? The ABI document in github suggests:
> 
>   X2-X15, X19-X29 and SP are call-preserved.
> 
> for `__arm_sme_state`, which is different to the comment, specifically the `X0-X13` bit.
Good spot, I've fixed this to add two calling conventions instead.


================
Comment at: llvm/test/CodeGen/AArch64/sme-get-pstatesm.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sme -verify-machineinstrs < %s | FileCheck %s
----------------
david-arm wrote:
> I assume you removed this line because you chopped out some unwanted CHECK lines after running the script?
I removed it, because otherwise it generates loads of CHECK lines for the RUN line with the `CHECK-CSRMASK` check-prefix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131571/new/

https://reviews.llvm.org/D131571