[PATCH] D131570: [AArch64][SME] Add utility class for handling SME attributes.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 06:49:07 PDT 2022


sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/Utils/AArch64SMEAttributes.cpp:76
+
+  return Callee.hasStreamingInterface() ? true : false;
+}
----------------
aemerson wrote:
> Just return the return value?
<facepalm>


================
Comment at: llvm/unittests/Target/AArch64/CMakeLists.txt:11
   AArch64Info
+  AsmParser
   CodeGen
----------------
aemerson wrote:
> Why?
It is needed for `parseAssemblyString`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131570/new/

https://reviews.llvm.org/D131570



More information about the llvm-commits mailing list