[PATCH] D130076: [llvm/CodeGen] Enable the ExpandLargeDivRem pass for X86, Arm and AArch64

Fri Sep 9 06:03:13 PDT 2022

aaron.ballman added a comment.

In D130076#3778557 <https://reviews.llvm.org/D130076#3778557>, @mgehre-amd wrote:

> In D130076#3777630 <https://reviews.llvm.org/D130076#3777630>, @aaron.ballman wrote:
>
>> In D130076#3771515 <https://reviews.llvm.org/D130076#3771515>, @FreddyYe wrote:
>>
>>> LGTM. Thanks @mgehre-amd for your great work to implementing this feature!
>>
>> Agreed, thank you for this work! Do you agree that we can now bump `BITINT_MAXWIDTH` in Clang above 128 now, or are we still missing support for that (floating-point conversions were also a problem IIRC)?
>
> Thanks back to everyone who helped by reviewing!
> Unfortunately, float-to-big-int and and big-int-to-float conversions still crash in the backend.
> I want to take a look at this next.

Thank you for confirming and the offer to look into fixing up that support as well. It's greatly appreciated!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130076/new/

https://reviews.llvm.org/D130076