[PATCH] D133524: [SLP]Improve reordering of clustered reused scalars.
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 9 05:33:56 PDT 2022
RKSimon added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3690
+ }
+ if (!UsedIndices.all())
+ return false;
----------------
Please can you pull the UsedIndices mask check out into a helper (isOneUseSingleSourceMask()?) - I'd like to get this moved into ShuffleVectorInst so its with all the other static shuffle mask kind matchers as this has potential uses elsewhere. Its up to you whether you put it there yourself in this patch, or just hoist it out as a helper in SLP for now.
I'm intending to add proper unit tests for the shuffle mask matches soon so I can do it then if necessary
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133524/new/
https://reviews.llvm.org/D133524
More information about the llvm-commits
mailing list