[PATCH] D133483: Add command line argument parsing to the Windows packaging script.

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/utils/release/build_llvm_release.bat:295
+    )
+    set "arg_name=%aux:~2,250%"
+  ) else (
----------------
CarlosAlbertoEnciso wrote:
> hans wrote:
> > I'm probably missing something, but for `--type=release` it seems like this would set `arg_name` to `type=release`? Or does it get split into the name and value in some way?
> > 
> > Or, it looks like the code would maybe work for `--type release`, but in that case the example above would need updating.
> > I'm probably missing something, but for `--type=release` it seems like this would set `arg_name` to `type=release`? Or does it get split into the name and value in some way?
> > 
> 
> The `=` sign in the command line is interpreted as argument separator. The same for space, comma and semicolon.
> 
> `--type=release` and `type release` are splitted in 2 arguments `--type` and `release`.
Interesting, I did not know Windows did that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133483/new/

https://reviews.llvm.org/D133483