[PATCH] D133287: [InstCombine] Test for matrix multiplication negation optimisation.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/matrix-multiplication-negation.ll:40
+
+; %b has the fewest vector elements between the result and the two operands so the negation can be moved there
+define <9 x double> @test_move_negation_to_first_operand(<3 x double> %a, <27 x double> %b) {
----------------
nit: %b  should be %a?


================
Comment at: llvm/test/Transforms/InstCombine/matrix-multiplication-negation.ll:64
+
+; %b as the fewest vector elements between the result and the two operands so the negation can be moved there
+define <15 x double> @test_negation_not_moved_second_operand(<5 x double> %a, <3 x double> %b) {
----------------
`s so the negation can be moved there` -> should be not moved?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133287/new/

https://reviews.llvm.org/D133287