[PATCH] D132325: [AArch64][CodeGen] Fold the mov and lsl into ubfiz

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm accepted this revision.
paulwalker-arm added a comment.

In D132325#3779167 <https://reviews.llvm.org/D132325#3779167>, @Allen wrote:

> hi @paulwalker-arm, I have updated the pattern with INSERT_SUBREG, Any further concerns? Thanks.

I've a small request to ensure we preserve an existing test but otherwise this looks good to me.  Thanks for persevering with the work.



================
Comment at: llvm/test/CodeGen/AArch64/aarch64-dynamic-stack-layout.ll:461-464
+; CHECK-MACHO: ubfiz	 x9, x0, #2, #32
+; CHECK-MACHO: ldr	d[[DARG:[0-9]+]], [x29, #32]
+; CHECK-MACHO: and	 x9, x9, #0x7fffffff0
 ; CHECK-MACHO: mov	 x10, sp
----------------
Your version of these `CHECK-MACHO` lines is missing `add	x9, x9, #15` that is fundamental to what the checks are validating.  I've checked myself and the add is present so you just need to re-add the `CHECK-MACHO` line itself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132325/new/

https://reviews.llvm.org/D132325