[PATCH] D131582: [AArch64][SME] Add support for arm_locally_streaming functions.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp:1162
   case ISD::EntryToken:
-    llvm_unreachable("EntryToken should have been excluded from the schedule!");
   case ISD::MERGE_VALUES:
----------------
?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1239
+  // passing a getVTList(MVT::Other, MVT::Glue) in its definition above led to a
+  // SegFault when trying to add the VTList.
+  EntryNode =
----------------
I think we need a better understanding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131582/new/

https://reviews.llvm.org/D131582