[PATCH] D133293: [Assignment Tracking][10/*] salvageDebugInfo for dbg.assign intrinsics

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 03:33:13 PDT 2022


Orlando updated this revision to Diff 459007.
Orlando marked 2 inline comments as done.
Orlando added a comment.

+ Address review comments

> Plus the caveat that to avoid regression, dbg.assign will need to support variadic value operands.

Is this also something that can be a TODO item, given that the feature is experimental? Similarly to the use of `Poison` there are no obvious problems that spring to mind, but it would involve further changes and testing (as well as there being the possibility of non-obvious problems lurking).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133293/new/

https://reviews.llvm.org/D133293

Files:
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/DebugInfo/Generic/assignment-tracking/salvage-value.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133293.459007.patch
Type: text/x-patch
Size: 7769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220909/6015985d/attachment.bin>


More information about the llvm-commits mailing list