[PATCH] D131578: [AArch64][SME] Implement ABI for calls from streaming-compatible functions.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:2345-2352
+  // In the case of a smstart/smstop before a unreachable,
+  // just remove the pseudo.
+  if (std::next(MI.getIterator()) == OrigBB->end() &&
+      MI.getParent()->successors().begin() ==
+      MI.getParent()->successors().end()) {
+    MI.eraseFromParent();
+    return OrigBB;
----------------
Not a big deal, but this seems like an odd optimization to do. One would think that this would be infrequent enough that we wouldn't need to add special handling for it, and if it's not infrequent, why?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131578/new/

https://reviews.llvm.org/D131578