[PATCH] D133485: [LICM] Allow promotion with non-load/store users

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.

LGTM.  Nice find!



================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2096
       } else
-        return false; // Not a load or store.
+        continue; // Not a load or store.
 
----------------
If you're interested, we can be smarter here for some uses.  e.g. a argument to a call marked experimental gives us deref facts.  (Though that requires guaranteed to execute reasoning - which for some reason we don't use for loads?)  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133485/new/

https://reviews.llvm.org/D133485