[PATCH] D133480: [llvm-dwp] Get the DWO file using relative path instead of absolute path to make it work for distribution build

Thu Sep 8 12:21:17 PDT 2022

dblaikie added a comment.

In D133480#3777196 <https://reviews.llvm.org/D133480#3777196>, @steven.zhang wrote:

> In D133480#3777059 <https://reviews.llvm.org/D133480#3777059>, @dblaikie wrote:
>
>> I don't think this is correct - the dwp tool might be run from a different directory than the equivalent comp_dir and so treating these as cwd-of-dwp-relative paths seems problematic.
>>
>> I think the correct thing to do in the situation described is for the compilation to use -fdebug-compilation-dir <https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fdebug-compilation-dir> to make the debug info portable - this will also ensure that a debugger can find the source and find the .dwo files even if they aren't packaged into a .dwp.
>
> Can we do it as what gdb did ? That is, getting the dwo from absolute path first, and if failed, get it from relative path ?

I'm somewhat open to that, though I'd really encourage you to switch your build system/build flags so you don't have to keep adding functionality like that into other debug info consuming tools.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133480/new/

https://reviews.llvm.org/D133480