[PATCH] D133514: [VP][VE] Default VP_SREM/UREM to Expand and add generic expansion using VP_SDIV/UDIV+VP_MUL+VP_SUB.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 11:53:53 PDT 2022


craig.topper created this revision.
craig.topper added reviewers: frasercrmck, simoll, efocht, kaz7.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added a project: LLVM.

I want to default all VP operations to Expand. These 2 were blocking
because VE doesn't support them and the tests were expecting them
to fail a specific way. Using Expand caused them to fail differently.

Seemed better to emulate them using operations that are supported.

@simoll mentioned on Discord that VE has some expansion downstream. Not
sure if its done like this or in the VE target.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133514

Files:
  llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
  llvm/lib/CodeGen/TargetLoweringBase.cpp
  llvm/test/CodeGen/VE/Vector/vp_srem.ll
  llvm/test/CodeGen/VE/Vector/vp_urem.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133514.458818.patch
Type: text/x-patch
Size: 12563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220908/bf231399/attachment.bin>


More information about the llvm-commits mailing list