[PATCH] D133394: [sanitizers] Invalidate GlobalsAA

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

In D133394#3777909 <https://reviews.llvm.org/D133394#3777909>, @vitalybuka wrote:

> In D133394#3777688 <https://reviews.llvm.org/D133394#3777688>, @aeubanks wrote:
>
>> also it would be nice to have some sort of check to detect this sort of issue with GlobalsAA and instrumentation passes, perhaps gated under expensive checks. haven't thought too hard on how that would work
>
> I assume not in this patch?

yeah not here, I'm just randomly throwing out ideas



================
Comment at: llvm/test/Instrumentation/MemorySanitizer/msan_invalidate.ll:7
+
+define dso_local noundef ptr @_Z10max_by_ptrPiS_(ptr noundef readonly %a, ptr noundef readonly %b) local_unnamed_addr sanitize_memory {
+entry:
----------------
if possible could you reduce this test case? e.g. dso_local/target datalayout/triple/lifetime/noundef


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133394/new/

https://reviews.llvm.org/D133394