[PATCH] D128302: [AArch64][CostModel] Detects that {Extract,Insert}Element at lane 0 have the same cost as other lanes for real instructions that operates on integer types

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 11:14:09 PDT 2022


davidxl added a comment.
Herald added a subscriber: pcwang-thead.

The patch looks reasonable to me. Check if @fhahn @RKSimon have further comments.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1972
     // The element at index zero is already inside the vector.
-    if (Index == 0)
+    // - For a physical (VirtualInst==false) insert-element or extract-element
+    // instruction that extracts integers, an explicit FPR -> GPR move is
----------------
VirtualInst--> HasRealUse.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128302/new/

https://reviews.llvm.org/D128302



More information about the llvm-commits mailing list