[PATCH] D133300: [InstCombine] Matrix multiplication negation optimisation

Zain Jaffal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 08:43:10 PDT 2022


zjaffal added a comment.

In D133300#3776842 <https://reviews.llvm.org/D133300#3776842>, @spatel wrote:

> What happens if both args are negated? We need a test for that. Maybe that pattern should be handled before this, so we don't have to deal with the complication in this patch?
>
> Tests should also include fast-math-flags in at least some cases, so we can see if those are propagated as expected.

I will add a test case for that now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133300/new/

https://reviews.llvm.org/D133300



More information about the llvm-commits mailing list