[PATCH] D113291: [AggressiveInstCombine] Lower Table Based CTTZ

Thu Sep 8 08:26:29 PDT 2022

djtodoro added a comment.

In D113291#3777195 <https://reviews.llvm.org/D113291#3777195>, @spatel wrote:

> In D113291#3777119 <https://reviews.llvm.org/D113291#3777119>, @djtodoro wrote:
>
>> @rsmith recommitted with f879939157 <https://reviews.llvm.org/rGf87993915768772d113bfd524347ce4341b843cf>. Thanks!
>
> What was the bug, how was it fixed, and is there a new test to verify the fix? That should have been mentioned in the new commit message.

You are right. I reverted the recommit, and I will recommit it with proper message, sorry I missed it. :/

Actually, the issue was that your patch D129167 <https://reviews.llvm.org/D129167> introduced `eraseFromParent` and the `tryToRecognizeTableBasedCttz` would try to use the instruction (`dyn_cast`) after free. I just moved the `tryToRecognizeTableBasedCttz` above `foldSqrt`. I guess it does not need any additional test case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113291/new/

https://reviews.llvm.org/D113291