[PATCH] D133483: Update Windows packaging script.
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 8 07:24:56 PDT 2022
hans added a comment.
Can you change the description from "Update Windows packaging script" which is pretty generic to something like "Add command line argument parsing to the Windows packaging script"?
================
Comment at: llvm/utils/release/build_llvm_release.bat:295
+ )
+ set "arg_name=%aux:~2,250%"
+ ) else (
----------------
I'm probably missing something, but for `--type=release` it seems like this would set `arg_name` to `type=release`? Or does it get split into the name and value in some way?
Or, it looks like the code would maybe work for `--type release`, but in that case the example above would need updating.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133483/new/
https://reviews.llvm.org/D133483
More information about the llvm-commits
mailing list