[PATCH] D131548: [AArch64]Remove svget/svset/svcreate from llvm

[Caroline via Phabricator via llvm-commits]

CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added inline comments.


================
Comment at: llvm/lib/IR/AutoUpgrade.cpp:3883-3884
+    StringRef Name = F->getName();
+    Name = Name.substr(5);
+    if (!Name.startswith("aarch64.sve.tuple")) {
+      DefaultCase();
----------------
sdesmalen wrote:
> Is the name guaranteed to start with `llvm.` ?
> 
> If not, I would think it makes more sense to write:
> 
>   `if (!Name.startswith("llvm.aarch64.sve.tuple")) {`
> 
> Also, should this be "tuple.get" instead of just "tuple" ?
If you look at line 561 in  UpgradeIntrinsicFunction1 you will see this:

```
 Name = Name.substr(5); // Strip off "llvm.
```
So I believe it is safe to assume it will start with llvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131548/new/

https://reviews.llvm.org/D131548