[PATCH] D133426: [LICM][LSR] Address a couple of special cases involving NULL.

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2101
+        }
+        return false; // Not a load or store and not null.
+      }
----------------
So, the null special case doesn't make a lot of sense to me, in that promoting a null pointer is pretty pointless -- those accesses are UB anyway, right?

However, I do think that that this bailout can be removed entirely: https://reviews.llvm.org/D133485


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133426/new/

https://reviews.llvm.org/D133426