[PATCH] D132591: [LV] Use safe-divisor lowering for fixed vectors if profitable
    David Sherwood via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Sep  8 05:24:48 PDT 2022
    
    
  
david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for making the changes @reames.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1442
 
+  bool isDivRemScalarWithPredication(InstructionCost ScalarCost,
+                                     InstructionCost SafeDivisorCost) const {
----------------
nit: I realise I asked you to add this function, but could you add a brief comment above this function before landing the patch?
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132591/new/
https://reviews.llvm.org/D132591
    
    
More information about the llvm-commits
mailing list