[PATCH] D133482: [LLVM] Fix GetErrcMessages.cmake module for WoA

Thu Sep 8 05:09:42 PDT 2022

omjavaid added a comment.

In D133482#3776778 <https://reviews.llvm.org/D133482#3776778>, @zero9178 wrote:

> If multi project configurators are a concern then some additional logic could be added via checking for `GENERATOR_IS_MULTI_CONFIG`[0] and then choosing one of the build types listed in `CMAKE_CONFIGURATION_TYPES`[1]. It shouldn't matter which one of them is chosen.

This looks like a good plan but as far as GetErrcMessages.cmake module is concerned we can also mark it to always run in release mode rather than choosing a config. Any thoughts on always running this module in release mode?

> In D133482#3776766 <https://reviews.llvm.org/D133482#3776766>, @mstorsjo wrote:
>
>> Alternatively, maybe we should back up and reset this variable to what it was set to before? So that we only affect this particular one. Then again, (my cmake is a bit unclear on this point), does setting it here, within a function, mean it doesn't affect things outside of this function? Then it's probably safe as such...
>
> CMake functions create a separate scope that is initialized with the parent scope, so this would be safe I believe.
>
> [0] https://cmake.org/cmake/help/latest/prop_gbl/GENERATOR_IS_MULTI_CONFIG.html
> [1] https://cmake.org/cmake/help/latest/variable/CMAKE_CONFIGURATION_TYPES.html#variable:CMAKE_CONFIGURATION_TYPES

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133482/new/

https://reviews.llvm.org/D133482