[PATCH] D132225: [Assignment Tracking][6/*] Add trackAssignments function

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 04:57:47 PDT 2022


jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/IR/DebugInfo.cpp:1781-1783
+  // Early-exit if there are no interesting variables.
+  if (Vars.empty())
+    return;
----------------
Orlando wrote:
> jmorse wrote:
> > Any need for "if Start == End return"?
> It's not needed for correctness (that's the loop stop condition and nothing happens after the loop) and I can't imagine that it's a case common enough to warrant the early-out. Happy to do it though if you think it's worth it.
No opinion really, just curious. No need for premature optimisation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132225/new/

https://reviews.llvm.org/D132225



More information about the llvm-commits mailing list