[PATCH] D132223: [Assignment Tracking][4/*] Add llvm.dbg.assign intrinsic boilerplate

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 03:36:35 PDT 2022


Orlando updated this revision to Diff 458698.
Orlando added a comment.

+ Tidy up comments in test (use `;;` rather than `;` for non-filecheck-directive comments)
+ Add `getRawX` versions of `DbgAssignIntrinsic` methods, following the other intrinsics' examples.
+ Call the `getRawX` functions in the verifier, rather than using hard-coded `getOperand(int)` calls.
+ Rename `getAssignId` -> `getAssignID`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132223/new/

https://reviews.llvm.org/D132223

Files:
  llvm/include/llvm/IR/IntrinsicInst.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/lib/IR/IntrinsicInst.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/roundtrip.ll
  llvm/test/DebugInfo/Generic/assignment-tracking/parse-and-verify/verify.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132223.458698.patch
Type: text/x-patch
Size: 19032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220908/3c68673d/attachment.bin>


More information about the llvm-commits mailing list