[PATCH] D126533: [LAA] Relax pointer dependency with runtime pointer checks
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 8 03:35:51 PDT 2022
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
I haven't looked at D132703 <https://reviews.llvm.org/D132703>, but I'm happy with the changes in this patch if you can address the final comments before landing.
================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/runtime-check-invariant-and-affine.ll:101-102
+
+for.cond.cleanup:
+ ret void
+
----------------
nit: move this below the for.body
================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/runtime-check-invariant-and-affine.ll:52-53
+; CHECK-LABEL: function 'srcaffine_sinkinvariant'
+; CHECK:Memory dependences are safe with run-time checks
+;
+entry:
----------------
Could you add CHECK lines for all the output, similar to what was done in e.g. llvm/test/Analysis/LoopAccessAnalysis/depend_diff_types.ll ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126533/new/
https://reviews.llvm.org/D126533
More information about the llvm-commits
mailing list