[PATCH] D133055: [MachineFunctionPass] Support -filter-passes for -print-changed

Thu Sep 8 01:19:36 PDT 2022

nikic added a comment.

In D133055#3776285 <https://reviews.llvm.org/D133055#3776285>, @aeubanks wrote:

> In D133055#3766237 <https://reviews.llvm.org/D133055#3766237>, @nikic wrote:
>
>> FYI there was some small but measurable compile-time impact, probably because you are looking up the pass info unconditionally, even if no printing is requested. (http://llvm-compile-time-tracker.com/compare.php?from=c0433f91d3333d8902ae7a53c0e5ee5e98b7586b&to=8d95fd7e56bed7d3a3260bed7117023968f8be3c&stat=instructions)
>
> hopefully fixed with 7e0a52e8e9ef6394bb62e0b56e17fa23e7262411 <https://reviews.llvm.org/rG7e0a52e8e9ef6394bb62e0b56e17fa23e7262411>

Thanks! Unfortunately the build was broken when this landed, so the results also include many other commits, but it does look good :) http://llvm-compile-time-tracker.com/compare.php?from=178554f3c8f983bd192818b6d46e4d95560c4964&to=fd2475049e882e6c70a745cbe0799749ba184910&stat=instructions

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133055/new/

https://reviews.llvm.org/D133055