[PATCH] D132901: [LLD] Imply "longjmp" in `/guard:cf`

Alvin Wong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 00:54:47 PDT 2022


alvinhochun added a comment.

In D132901#3776411 <https://reviews.llvm.org/D132901#3776411>, @mstorsjo wrote:

> In D132901#3760680 <https://reviews.llvm.org/D132901#3760680>, @pengfei wrote:
>
>> Great job! Thanks @alvinhochun !
>>
>> If we consider the `longjmp` not enabling long jump is a bug, and fix the table accordingly, then it is exactly what LLD is doing with this patch. It looks to me MSVC handles the options in order too. Anyway, it matches my understanding in options parsing.
>
> @alvinhochun Does this patch seem ok to you in this form, or do you think it would make sense to match link.exe's behaviour wrt longjmp more exactly?

I think this patch in its current form is probably fine but honestly I don't know. It would be nice to have a second opinion from someone who actually use the MSVC toolchain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132901/new/

https://reviews.llvm.org/D132901



More information about the llvm-commits mailing list