[PATCH] D133287: [InstCombine] Test for matrix multiplication negation optimisation.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 00:50:11 PDT 2022


fhahn added a comment.

Thanks for the update! Could you also add quick comments to the test cases documenting the expected behavior? It would also good to have test cases with chains of matrix multiplies, where some arguments are negated. They don't need to be optimized by the first patch, but it would be good to make sure we do not crash on such cases (or run into an instcombine cycle)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133287/new/

https://reviews.llvm.org/D133287



More information about the llvm-commits mailing list