[PATCH] D133028: [amdgpu] Always, instead of mostly, remove unused LDS symbols

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 8 00:04:53 PDT 2022


foad added a comment.

In D133028#3774623 <https://reviews.llvm.org/D133028#3774623>, @JonChesterfield wrote:

> Guessing in the other direction, please let me know if you want the braces put back in for the `for`.

The LLVM rules <https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements> are complicated -- too complicated in my opinion. In AMDGPU code we usually omit braces if the thing inside them would be a single line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133028/new/

https://reviews.llvm.org/D133028



More information about the llvm-commits mailing list