[PATCH] D133153: [support] Prepare TimeProfiler for cross-thread support

[Mark Shields via Phabricator via llvm-commits]

mbs-modular added a comment.

Afraid I'm out of ideas.

> Accidentally changed the clock.

No, looks good.

> Despite all the profile writing code not depending on raw_pwrite_stream statically, there's some magic that saves profile writing time

Can't detect a difference.

> I'm not looking at a large enough run.

  CLANG="/usr/bin/clang++-14"
  CLANG="/home/mbs/github/mbs-llvm-project/build/bin/clang++"
  CMD="$CLANG -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/mbs/github/mbs-llvm-project/build/lib/Analysis -I/home/mbs/github/mbs-llvm-project/llvm/lib/Analysis -I/home/mbs/github/mbs-llvm-project/build/include -I/home/mbs/github/mbs-llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -fno-rtti -std=c++17 -MD -MT lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ValueTracking.cpp.o -MF lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ValueTracking.cpp.o.d -o lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ValueTracking.cpp.o -c /home/mbs/github/mbs-llvm-project/llvm/lib/Analysis/ValueTracking.cpp"

Seems in the noise to me:

  main	main	branch	branch	pwrite	pwrite
  none	flag	none	flag	none	flag
  5.7	5.74	5.55	5.69	5.58	5.61
  5.65	5.71	5.52	5.67	5.54	5.57
  5.61	5.82	5.98	5.74	5.3	5.53
  5.66	5.84	6.49	5.72	5.45	5.53
  5.8	6.11	6.1	5.86	5.36	5.62
  5.77	5.68	5.78	5.71	5.39	5.52
  5.76	5.88	5.57	5.84	5.39	5.56
  5.77	5.75	5.87	5.92	5.41	5.46
  5.78	5.79	6.03	5.87	5.41	5.52
  5.73	5.77	6.53	6.07	5.44	5.5
  5.71	5.66	5.58	5.94	5.39	5.55
  5.64	5.61	5.6	5.87	5.43	5.53
  5.76	5.65	5.49	5.7	5.38	5.55
  5.62	5.59	5.52	5.69	5.32	5.52
  5.64	5.74	5.69	5.76	5.32	5.55
  
  5.71	5.74	5.69	5.76	5.39	5.53   (means)
  	1.005		1.012		1.026  (factors)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133153/new/

https://reviews.llvm.org/D133153