[PATCH] D133467: [BOLT][TEST] Replace dynamic exception specification with noexcept(false)

Amir Ayupov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 19:43:31 PDT 2022


Amir updated this revision to Diff 458628.
Amir added a comment.

Remove filter_only as dynamic exception specification behavior wasn't tested in
BOLT


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133467/new/

https://reviews.llvm.org/D133467

Files:
  bolt/test/runtime/X86/Inputs/exception3.cpp
  bolt/test/runtime/X86/Inputs/exception4.cpp


Index: bolt/test/runtime/X86/Inputs/exception4.cpp
===================================================================
--- bolt/test/runtime/X86/Inputs/exception4.cpp
+++ bolt/test/runtime/X86/Inputs/exception4.cpp
@@ -16,10 +16,6 @@
     throw ExcC();
 }
 
-void filter_only(int a) throw (ExcA, ExcB, ExcC, ExcD, ExcE, ExcF) {
-  foo(a);
-}
-
 void never_throws() throw () {
   printf("this statement is cold and should be outlined\n");
 }
@@ -46,7 +42,7 @@
 
     try {
       try {
-        filter_only(argc);
+        foo(argc);
       } catch (ExcC) {
         printf("caught ExcC\n");
       }
Index: bolt/test/runtime/X86/Inputs/exception3.cpp
===================================================================
--- bolt/test/runtime/X86/Inputs/exception3.cpp
+++ bolt/test/runtime/X86/Inputs/exception3.cpp
@@ -16,10 +16,6 @@
     throw ExcC();
 }
 
-void filter_only(int a) throw (ExcA, ExcB, ExcC, ExcD, ExcE, ExcF) {
-  foo(a);
-}
-
 int main(int argc, char **argv)
 {
   asm volatile ("nop;nop;nop;nop;nop");
@@ -41,7 +37,7 @@
     asm volatile ("nop;nop;nop;nop;nop");
     try {
       asm volatile ("nop;nop;nop;nop;nop");
-      filter_only(argc);
+      foo(argc);
     } catch (ExcC) {
       asm volatile ("nop;nop;nop;nop;nop");
       printf("caught ExcC\n");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133467.458628.patch
Type: text/x-patch
Size: 1281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220908/61560e03/attachment.bin>


More information about the llvm-commits mailing list