[PATCH] D133166: [mlir][MemRef] Canonicalize extract_strided_metadata(subview)

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 16:33:51 PDT 2022


qcolombet updated this revision to Diff 458600.
qcolombet added a comment.

- Remove lambdas and use ternary op instead
- Use `getIndexAttr` instead of `getValueOrCreateConstantIndexOp`
- Merge the offset computation loop and the strides computation loop
- Fix typos


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133166/new/

https://reviews.llvm.org/D133166

Files:
  mlir/include/mlir/Dialect/MemRef/Transforms/Passes.h
  mlir/include/mlir/Dialect/MemRef/Transforms/Passes.td
  mlir/include/mlir/IR/AffineExpr.h
  mlir/lib/Dialect/MemRef/Transforms/CMakeLists.txt
  mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp
  mlir/test/Dialect/MemRef/simplify-extract-strided-metadata.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133166.458600.patch
Type: text/x-patch
Size: 25457 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220907/2b06f7de/attachment-0001.bin>


More information about the llvm-commits mailing list