[llvm] a002fd6 - [InstCombine] Baseline tests for folding x + (x | -x) to x & (x - 1)
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 7 16:13:09 PDT 2022
Author: Marc Auberer
Date: 2022-09-07T19:12:23-04:00
New Revision: a002fd667813c93d32f79f19c5e17e0b2343bf38
URL: https://github.com/llvm/llvm-project/commit/a002fd667813c93d32f79f19c5e17e0b2343bf38
DIFF: https://github.com/llvm/llvm-project/commit/a002fd667813c93d32f79f19c5e17e0b2343bf38.diff
LOG: [InstCombine] Baseline tests for folding x + (x | -x) to x & (x - 1)
Baseline tests for D133362
Differential Revision: https://reviews.llvm.org/D133449
Added:
llvm/test/Transforms/InstCombine/add_or_sub.ll
Modified:
Removed:
################################################################################
diff --git a/llvm/test/Transforms/InstCombine/add_or_sub.ll b/llvm/test/Transforms/InstCombine/add_or_sub.ll
new file mode 100644
index 0000000000000..6ccb8864ae267
--- /dev/null
+++ b/llvm/test/Transforms/InstCombine/add_or_sub.ll
@@ -0,0 +1,226 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+
+declare void @use19(i19)
+declare void @use12(i12)
+declare void @use2(i2)
+
+define i32 @add_or_sub_comb_i32_commuted1(i32 %x) {
+; CHECK-LABEL: @add_or_sub_comb_i32_commuted1(
+; CHECK-NEXT: [[SUB:%.*]] = sub i32 0, [[X:%.*]]
+; CHECK-NEXT: [[OR:%.*]] = or i32 [[SUB]], [[X]]
+; CHECK-NEXT: [[ADD:%.*]] = add i32 [[OR]], [[X]]
+; CHECK-NEXT: ret i32 [[ADD]]
+;
+ %sub = sub i32 0, %x
+ %or = or i32 %sub, %x
+ %add = add i32 %or, %x
+ ret i32 %add
+}
+
+define i8 @add_or_sub_comb_i8_commuted2(i8 %p) {
+; CHECK-LABEL: @add_or_sub_comb_i8_commuted2(
+; CHECK-NEXT: [[X:%.*]] = mul i8 [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub i8 0, [[X]]
+; CHECK-NEXT: [[OR:%.*]] = or i8 [[X]], [[SUB]]
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[X]], [[OR]]
+; CHECK-NEXT: ret i8 [[ADD]]
+;
+ %x = mul i8 %p, %p ; thwart complexity-based canonicalization
+ %sub = sub i8 0, %x
+ %or = or i8 %sub, %x
+ %add = add i8 %x, %or
+ ret i8 %add
+}
+
+define i128 @add_or_sub_comb_i128_commuted3(i128 %p) {
+; CHECK-LABEL: @add_or_sub_comb_i128_commuted3(
+; CHECK-NEXT: [[X:%.*]] = mul i128 [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub i128 0, [[X]]
+; CHECK-NEXT: [[OR:%.*]] = or i128 [[X]], [[SUB]]
+; CHECK-NEXT: [[ADD:%.*]] = add i128 [[OR]], [[X]]
+; CHECK-NEXT: ret i128 [[ADD]]
+;
+ %x = mul i128 %p, %p ; thwart complexity-based canonicalization
+ %sub = sub i128 0, %x
+ %or = or i128 %x, %sub
+ %add = add i128 %or, %x
+ ret i128 %add
+}
+
+define i64 @add_or_sub_comb_i64_commuted4(i64 %p) {
+; CHECK-LABEL: @add_or_sub_comb_i64_commuted4(
+; CHECK-NEXT: [[X:%.*]] = mul i64 [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub i64 0, [[X]]
+; CHECK-NEXT: [[OR:%.*]] = or i64 [[X]], [[SUB]]
+; CHECK-NEXT: [[ADD:%.*]] = add i64 [[X]], [[OR]]
+; CHECK-NEXT: ret i64 [[ADD]]
+;
+ %x = mul i64 %p, %p ; thwart complexity-based canonicalization
+ %sub = sub i64 0, %x
+ %or = or i64 %x, %sub
+ %add = add i64 %x, %or
+ ret i64 %add
+}
+
+define <3 x i32> @add_or_sub_comb_i32vec(<3 x i32> %p) {
+; CHECK-LABEL: @add_or_sub_comb_i32vec(
+; CHECK-NEXT: [[X:%.*]] = mul <3 x i32> [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub <3 x i32> zeroinitializer, [[X]]
+; CHECK-NEXT: [[OR:%.*]] = or <3 x i32> [[X]], [[SUB]]
+; CHECK-NEXT: [[ADD:%.*]] = add <3 x i32> [[OR]], [[X]]
+; CHECK-NEXT: ret <3 x i32> [[ADD]]
+;
+ %x = mul <3 x i32> %p, %p ; thwart complexity-based canonicalization
+ %sub = sub <3 x i32> <i32 0, i32 0, i32 0>, %x
+ %or = or <3 x i32> %sub, %x
+ %add = add <3 x i32> %or, %x
+ ret <3 x i32> %add
+}
+
+define <4 x i16> @add_or_sub_comb_i32vec_poison(<4 x i16> %p) {
+; CHECK-LABEL: @add_or_sub_comb_i32vec_poison(
+; CHECK-NEXT: [[X:%.*]] = mul <4 x i16> [[P:%.*]], [[P]]
+; CHECK-NEXT: [[ADD:%.*]] = add <4 x i16> [[X]], <i16 -1, i16 -1, i16 -1, i16 -1>
+; CHECK-NEXT: ret <4 x i16> [[ADD]]
+;
+ %x = mul <4 x i16> %p, %p ; thwart complexity-based canonicalization
+ %sub = sub <4 x i16> <i16 -1, i16 poison, i16 poison, i16 -1>, %x
+ %or = or <4 x i16> %sub, %x
+ %add = add <4 x i16> %or, %x
+ ret <4 x i16> %add
+}
+
+define i12 @add_or_sub_comb_i12_multiuse_only_sub(i12 %p) {
+; CHECK-LABEL: @add_or_sub_comb_i12_multiuse_only_sub(
+; CHECK-NEXT: [[X:%.*]] = mul i12 [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub i12 0, [[X]]
+; CHECK-NEXT: call void @use12(i12 [[SUB]])
+; CHECK-NEXT: [[OR:%.*]] = or i12 [[X]], [[SUB]]
+; CHECK-NEXT: [[ADD:%.*]] = add i12 [[OR]], [[X]]
+; CHECK-NEXT: ret i12 [[ADD]]
+;
+ %x = mul i12 %p, %p ; thwart complexity-based canonicalization
+ %sub = sub i12 0, %x
+ call void @use12(i12 %sub) ; extra use of sub
+ %or = or i12 %sub, %x
+ %add = add i12 %or, %x
+ ret i12 %add
+}
+
+define i2 @add_or_sub_comb_i2_multiuse_only_or(i2 %p) {
+; CHECK-LABEL: @add_or_sub_comb_i2_multiuse_only_or(
+; CHECK-NEXT: [[X:%.*]] = mul i2 [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub i2 0, [[X]]
+; CHECK-NEXT: [[OR:%.*]] = or i2 [[X]], [[SUB]]
+; CHECK-NEXT: call void @use2(i2 [[OR]])
+; CHECK-NEXT: [[ADD:%.*]] = add i2 [[OR]], [[X]]
+; CHECK-NEXT: ret i2 [[ADD]]
+;
+ %x = mul i2 %p, %p ; thwart complexity-based canonicalization
+ %sub = sub i2 0, %x
+ %or = or i2 %sub, %x
+ call void @use2(i2 %or) ; extra use of or
+ %add = add i2 %or, %x
+ ret i2 %add
+}
+
+define i19 @add_or_sub_comb_i19_multiuse_both(i19 %p) {
+; CHECK-LABEL: @add_or_sub_comb_i19_multiuse_both(
+; CHECK-NEXT: [[X:%.*]] = mul i19 [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub i19 0, [[X]]
+; CHECK-NEXT: call void @use19(i19 [[SUB]])
+; CHECK-NEXT: [[OR:%.*]] = or i19 [[X]], [[SUB]]
+; CHECK-NEXT: call void @use19(i19 [[OR]])
+; CHECK-NEXT: [[ADD:%.*]] = add i19 [[OR]], [[X]]
+; CHECK-NEXT: ret i19 [[ADD]]
+;
+ %x = mul i19 %p, %p ; thwart complexity-based canonicalization
+ %sub = sub i19 0, %x
+ call void @use19(i19 %sub) ; extra use of sub
+ %or = or i19 %sub, %x
+ call void @use19(i19 %or) ; extra use of or
+ %add = add i19 %or, %x
+ ret i19 %add
+}
+
+define i10 @add_or_sub_comb_i10_nsw_nuw(i10 %p) {
+; CHECK-LABEL: @add_or_sub_comb_i10_nsw_nuw(
+; CHECK-NEXT: [[X:%.*]] = mul i10 [[P:%.*]], [[P]]
+; CHECK-NEXT: [[SUB:%.*]] = sub i10 0, [[X]]
+; CHECK-NEXT: [[OR:%.*]] = or i10 [[X]], [[SUB]]
+; CHECK-NEXT: [[ADD:%.*]] = add nuw nsw i10 [[OR]], [[X]]
+; CHECK-NEXT: ret i10 [[ADD]]
+;
+ %x = mul i10 %p, %p ; thwart complexity-based canonicalization
+ %sub = sub i10 0, %x
+ %or = or i10 %sub, %x
+ %add = add nsw nuw i10 %or, %x
+ ret i10 %add
+}
+
+define i8 @add_or_sub_comb_i8_negative1(i8 %x, i8 %y) {
+; CHECK-LABEL: @add_or_sub_comb_i8_negative1(
+; CHECK-NEXT: [[SUB:%.*]] = sub i8 0, [[Y:%.*]]
+; CHECK-NEXT: [[OR:%.*]] = or i8 [[SUB]], [[X:%.*]]
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[OR]], [[X]]
+; CHECK-NEXT: ret i8 [[ADD]]
+;
+ %sub = sub i8 0, %y ; mismatch: y instead of x
+ %or = or i8 %sub, %x
+ %add = add i8 %or, %x
+ ret i8 %add
+}
+
+define i8 @add_or_sub_comb_i8_negative2(i8 %x, i8 %y) {
+; CHECK-LABEL: @add_or_sub_comb_i8_negative2(
+; CHECK-NEXT: [[SUB:%.*]] = sub i8 0, [[X:%.*]]
+; CHECK-NEXT: [[OR:%.*]] = or i8 [[SUB]], [[Y:%.*]]
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[OR]], [[X]]
+; CHECK-NEXT: ret i8 [[ADD]]
+;
+ %sub = sub i8 0, %x
+ %or = or i8 %sub, %y ; mismatch: y instead of x
+ %add = add i8 %or, %x
+ ret i8 %add
+}
+
+define i8 @add_or_sub_comb_i8_negative3(i8 %x, i8 %y) {
+; CHECK-LABEL: @add_or_sub_comb_i8_negative3(
+; CHECK-NEXT: [[SUB:%.*]] = sub i8 0, [[X:%.*]]
+; CHECK-NEXT: [[OR:%.*]] = or i8 [[SUB]], [[X]]
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[OR]], [[Y:%.*]]
+; CHECK-NEXT: ret i8 [[ADD]]
+;
+ %sub = sub i8 0, %x
+ %or = or i8 %sub, %x
+ %add = add i8 %or, %y ; mismatch: y instead of x
+ ret i8 %add
+}
+
+define i8 @add_or_sub_comb_i8_negative4(i8 %x) {
+; CHECK-LABEL: @add_or_sub_comb_i8_negative4(
+; CHECK-NEXT: [[SUB:%.*]] = sub i8 0, [[X:%.*]]
+; CHECK-NEXT: [[XOR:%.*]] = xor i8 [[SUB]], [[X]]
+; CHECK-NEXT: [[ADD:%.*]] = add i8 [[XOR]], [[X]]
+; CHECK-NEXT: ret i8 [[ADD]]
+;
+ %sub = sub i8 0, %x
+ %xor = xor i8 %sub, %x ; mismatch: xor instead of or
+ %add = add i8 %xor, %x
+ ret i8 %add
+}
+
+
+define i16 @add_or_sub_comb_i16_negative5(i16 %x) {
+; CHECK-LABEL: @add_or_sub_comb_i16_negative5(
+; CHECK-NEXT: [[SUB:%.*]] = sub i16 1, [[X:%.*]]
+; CHECK-NEXT: [[OR:%.*]] = or i16 [[SUB]], [[X]]
+; CHECK-NEXT: [[ADD:%.*]] = add i16 [[OR]], [[X]]
+; CHECK-NEXT: ret i16 [[ADD]]
+;
+ %sub = sub i16 1, %x ; mismatch: sub isn't a negate
+ %or = or i16 %sub, %x
+ %add = add i16 %or, %x
+ ret i16 %add
+}
More information about the llvm-commits
mailing list