[PATCH] D133334: [AMDGPU][MC] Warn when disassembling v_cmpx instructions

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:719
+      Desc.hasImplicitDefOfPhysReg(AMDGPU::EXEC) && MI.getNumOperands() >= 5 &&
+      !OpIsExec(MI.getOperand(1)) && !OpIsZero(MI.getOperand(3))) {
+    outs() << "Warning: unexpected dst value\n";
----------------
gandhi21299 wrote:
> dp wrote:
> > This code checks operands of decoded `MCInst`, but decoded instruction does not provide any information about what `dst` was encoded in the original binary representation. To check the `dst` value, we have to work with the original binary code.
> > 
> Do you mean use `Bytes` instead?
Yes, we should use `Bytes`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133334/new/

https://reviews.llvm.org/D133334