[PATCH] D132378: [LLVM][TableGen] Add jupyter kernel for llvm-tblgen

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 13:27:03 PDT 2022


awarzynski added a comment.

Thanks for doing this!

I've only had the time go over and to run  "LLVM TableGen.md" - everything worked fine  and the examples make sense to me.  If only there was no empty space in the filename ;-) Btw, why do you need an *.md and *.ipynb file?



================
Comment at: llvm/utils/TableGen/jupyter/README.md:3
+
+Then install into jupyter:
+
----------------
?


================
Comment at: llvm/utils/TableGen/jupyter/README.md:31
+```shell
+    python3 tablgen_kernel/kernel.py
+```
----------------



================
Comment at: llvm/utils/TableGen/jupyter/tablegen_kernel/__init__.py:4
+# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+"""A llvm-tblgen kernel for Jupyter"""
+
----------------
I think that I am right, but I might be wrong ;-) (https://www.pristineword.com/grammar-an-l/)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132378/new/

https://reviews.llvm.org/D132378



More information about the llvm-commits mailing list