[PATCH] D133430: [SLP] Unify main/alternate instruction logic for CmpInst instructions - draft

Valeriy Dmitriev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 10:56:14 PDT 2022


vdmitrie added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:5809
+    Optional<bool> IsMain = isCmpSameOrSwapped(MainCI, cast<CmpInst>(I));
+    return !IsMain;
   }
----------------
ABataev wrote:
> `!*IsMain`?
Nope. The intent is check the optional does not have a value. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133430/new/

https://reviews.llvm.org/D133430



More information about the llvm-commits mailing list