[PATCH] D132494: [AIX] llvm-nm support environment "OBJECT_MODE" for option -X on AIX OS

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/option-X-AIX.test:62
+
+## environment variable "OBJECT_MODE" on archive.
+# RUN: llvm-nm --format=just-symbols %t.a | \
----------------
jhenderson wrote:
> 
I think we do not need to test the archive here.


================
Comment at: llvm/test/tools/llvm-nm/option-X-Non-AIX.test:1
+# REQUIRES: !system-aix
+
----------------
jhenderson wrote:
> I've taken another look at this test and am wondering what the test gives us above what regular llvm-nm tests give us?
the default behavior of llvm-nm is different of AIX os and on Non-AIX os.

If in Non-AIX OS , if there is no -X option in llvm-nm command the default value of -X is any bits.  (and the Non-AIX also ignore the  OBJECT_MODE environment).

but for the AIX OS.  if there is no -X option in llvm-nm command the default value of -X is 32 bits(if there is no OBJECT_MODE environment).

so we need separate test case to test the default value of -X in Non-AIX os.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132494/new/

https://reviews.llvm.org/D132494