[PATCH] D133067: [AMDGPU] W/a hazard if 64 bit shift amount is a highest allocated VGPR

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 09:55:38 PDT 2022


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:311
+  EmitInstruction(MI);
+  AdvanceCycle();
+}
----------------
kerbowa wrote:
> Do you need to reset CurrCycleInstr after calling this function? Should this work with process bundles?
`AdvanceCycle()` sets `CurrCycleInstr` to nullptr itself.

Good point about bundle, fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133067/new/

https://reviews.llvm.org/D133067



More information about the llvm-commits mailing list