[PATCH] D133418: [ConstantExpr] Remove fneg expression

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 08:33:42 PDT 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor comment.



================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:1391
 
-  return !ExpandConstantExprs;
+  switch (Opcode) {
+    case Instruction::FNeg:
----------------
Using a switch here looks odd as opposed to an early return if.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133418/new/

https://reviews.llvm.org/D133418



More information about the llvm-commits mailing list