[PATCH] D131960: [IR] Reimplement time tracing of NewPassManager by PassInstrumentation framework

[Jamie Schmeiser via Phabricator via llvm-commits]

jamieschmeiser accepted this revision.
jamieschmeiser added a comment.
This revision is now accepted and ready to land.

A couple of nits left:  small edits to comments and the change of "...() == nullptr" to "!...()" and it is good to go.
LGTM.



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:2111
+  // BeforeCallbacks by calling `registerCallbacks` in the end.
+  // Its 'AfterPassCallback' can be putted into the front of all the
+  // AfterCallbacks by its `registerCallbacks`.
----------------



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:2112
+  // Its 'AfterPassCallback' can be putted into the front of all the
+  // AfterCallbacks by its `registerCallbacks`.
+  TimeProfilingPasses.registerCallbacks(PIC);
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131960/new/

https://reviews.llvm.org/D131960