[PATCH] D133356: [AMDGPU][MC][GFX11][NFC] Update disassembler tests for VOP3.DPP16 instructions

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 06:29:36 PDT 2022


dp added a comment.

In D133356#3772653 <https://reviews.llvm.org/D133356#3772653>, @Joe_Nash wrote:

> I realized we don't have any asm or disasm coverage of v_fmac_.*_e64_dpp, and the asm at least is broken. 
> https://github.com/llvm/llvm-project/issues/57585
>
> That said, this patch does not claim to be bringing VOP3DPP up to full coverage. So LGTM

Sure, there are no tests for opcodes and features that have not passed testing. With these exceptions, I believe we now have good test coverage for GFX11 (3 final updates are in the review).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133356/new/

https://reviews.llvm.org/D133356



More information about the llvm-commits mailing list