[PATCH] D133292: [Assignment Tracking][9/*] Don't drop DIAssignID in dropUnknownNonDebugMetadata

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

LGTM



================
Comment at: llvm/lib/IR/Metadata.cpp:1312-1313
   KnownSet.insert(KnownIDs.begin(), KnownIDs.end());
+  // We rarely want to drop DIAssignID so make it difficult to do so
+  // accidentally.
+  KnownSet.insert(LLVMContext::MD_DIAssignID);
----------------
AS "NonDebug" is in the name of the function, we can probably get away with saying "DIAssignID is debug metadata, don't drop it".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133292/new/

https://reviews.llvm.org/D133292