[PATCH] D133396: [MemorySSA] Don't do addr phi translation if addr value is not a loop invariant

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 7 01:24:46 PDT 2022


nikic added a comment.

In D133396#3773866 <https://reviews.llvm.org/D133396#3773866>, @nikic wrote:

> You need to update phi-translation.ll for this change. From a cursory look I think the results improve while still being correct.

This is because PerformedPhiTranslation no longer gets set. After looking a bit closer, I think this flag is a leftover from an old implementation. Submitted https://reviews.llvm.org/D133404 to remove.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133396/new/

https://reviews.llvm.org/D133396



More information about the llvm-commits mailing list