[PATCH] D133166: [mlir][MemRef] Canonicalize extract_strided_metadata(subview)

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added inline comments.


================
Comment at: mlir/test/Dialect/MemRef/simplify-extract-strided-metadata.mlir:219
+//
+//  CHECK-DAG: %[[FINAL_OFFSET:.*]] = affine.apply #[[$OFFSET_MAP]]()[%[[DYN_OFFSET2]], %[[DYN_OFFSET1]], %[[OFFSET]], %[[DYN_OFFSET0]], %[[STRIDES]]#0, %[[DYN_STRIDE0]], %[[STRIDES]]#1, %[[DYN_STRIDE1]], %[[STRIDES]]#2, %[[DYN_STRIDE2]]]
+//
----------------
Nit question: Is there a way to produce an affine map, with a nice ordering of the arguments?
E.g., origOffset, stride0, subStride0, subOffset0, ...

Although the current map is correct, the arguments are all over the place :).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133166/new/

https://reviews.llvm.org/D133166