[PATCH] D132708: [MC] Emit Stackmaps before debug info

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 16:00:52 PDT 2022


lhames added a comment.

> The current approach of special casing for the __LLVM_STACKMAPS section is not viable either, as downstream users can overwrite the stackmap format using plugins, which may want to use different sections.

@zero9178 Could you elaborate on this? Was `__LLVM_STACKMAPS` handling being special cased in assertions in LLVM, or in tools that consumed MachO?

What do you mean by "downstream users can overwrite the stackmap format using plugins"? When do those plugins run, and how would they interfere with the special casing?

I don't mind this approach, but am curious about the design constraints on stack maps and how they're being used at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132708/new/

https://reviews.llvm.org/D132708



More information about the llvm-commits mailing list