[PATCH] D133218: [lld-macho] Hardlink -object_path_lto files to cache when possible

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 14:45:48 PDT 2022


steven_wu accepted this revision.
steven_wu added a comment.

LGTM. Small comment inline.



================
Comment at: lld/test/MachO/lto-object-path.ll:26
+; RUN: %lld %t/test.o -o %t/test -object_path_lto %t/lto-temps -prune_interval_lto 20 -cache_path_lto %t/cache --thinlto-cache-policy=cache_size_files=10:cache_size_bytes=10000
+; RUN: ls -l %t/lto-temps/1.x86_64.lto.o | cut -f 3 -d ' ' | FileCheck %s --check-prefix=HARDLINK
+
----------------
Would be good to add a short comment about what this is testing. It is not obvious that you are reading the number of links field from ls long format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133218/new/

https://reviews.llvm.org/D133218



More information about the llvm-commits mailing list