[PATCH] D133378: [ThinLTOBitcodeWriter] Mark pass as required

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added a reviewer: asbirlea.
Herald added subscribers: ormris, steven_wu, hiraditya, inglorion.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Or else with -opt-bisect-limit we don't write ThinLTO bitcode.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133378

Files:
  llvm/include/llvm/Transforms/IPO/ThinLTOBitcodeWriter.h
  llvm/test/Other/opt-bisect-new-pass-manager.ll


Index: llvm/test/Other/opt-bisect-new-pass-manager.ll
===================================================================
--- llvm/test/Other/opt-bisect-new-pass-manager.ll
+++ llvm/test/Other/opt-bisect-new-pass-manager.ll
@@ -99,6 +99,10 @@
 ; RUN: opt %s -opt-bisect-limit=0 -passes=early-cse -S | FileCheck %s -check-prefix=CHECK-OUTPUT
 ; CHECK-OUTPUT: define void @f1
 
+; Make sure we write ThinLTO bitcode
+; RUN: opt %s -opt-bisect-limit=0 -disable-verify -thinlto-bc -o /dev/null 2>&1 | FileCheck --allow-empty %s -check-prefix=CHECK-THINLTO
+; CHECK-THINLTO-NOT: NOT running pass
+
 declare i32 @g()
 
 define void @f1() {
Index: llvm/include/llvm/Transforms/IPO/ThinLTOBitcodeWriter.h
===================================================================
--- llvm/include/llvm/Transforms/IPO/ThinLTOBitcodeWriter.h
+++ llvm/include/llvm/Transforms/IPO/ThinLTOBitcodeWriter.h
@@ -34,6 +34,8 @@
       : OS(OS), ThinLinkOS(ThinLinkOS) {}
 
   PreservedAnalyses run(Module &M, ModuleAnalysisManager &AM);
+
+  static bool isRequired() { return true; }
 };
 
 } // namespace llvm


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133378.458281.patch
Type: text/x-patch
Size: 1086 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220906/feb66a20/attachment.bin>