[PATCH] D133232: [msan] Disambiguate warnings debug location

[Florian Mayer via Phabricator via llvm-commits]

fmayer added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:148
 #include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/DenseSet.h"
 #include "llvm/ADT/DepthFirstIterator.h"
----------------
should be DenseMap?


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1143-1146
+  // Creates new origin and record the stack trace. In general we can call this
+  // function for any origin manupulation we like. However it will cost runtime
+  // resources. So use this wisely only it can provide additional information
+  // helpfull to a user.
----------------
nits: manupulation, helpfull, only it -> only if it


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1287
+        auto NewDebugLoc = OI->getDebugLoc();
+        // Origin update with missing or the same debug locaton provides no
+        // additional value.
----------------
nit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133232/new/

https://reviews.llvm.org/D133232