[PATCH] D131960: [IR] Reimplement time tracing of NewPassManager by PassInstrumentation framework

[Jamie Schmeiser via Phabricator via llvm-commits]

jamieschmeiser added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:2109
+  // TimeProfiling must be the end instrumentation
+  TimeProfilingPasses.registerCallbacks(PIC);
 }
----------------
This comment should be expanded to indicate why it must be the last instrumentation (ie, so that it is the last instrumentation before the pass and that this also ensures that the after routines are truly put at the front so that other instrumentations are not included in the timing).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131960/new/

https://reviews.llvm.org/D131960